After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726611 - socketclient: Leak on cancellation
socketclient: Leak on cancellation
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
2.39.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-03-18 04:22 UTC by Olivier Crête
Modified: 2014-03-23 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
socketclient: Fix leak (846 bytes, patch)
2014-03-18 04:22 UTC, Olivier Crête 		accepted-commit_after_freeze Details | Review
gio: fix two more g_task_return_error_if_cancelled() leaks (1.42 KB, patch)
2014-03-18 13:57 UTC, Dan Winship 		committed Details | Review
socketclient: Fix leak (845 bytes, patch)
2014-03-23 14:58 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2014-03-18 04:22:09 UTC 
Created attachment 272231 [details] [review]
socketclient: Fix leak

On cancellation, the GTask is never being freed.. I hope I understood all of the variou bits there, this is suprisingly complicated code.
Comment 1 Dan Winship 2014-03-18 13:49:10 UTC 
Comment on attachment 272231 [details] [review]
socketclient: Fix leak

ok, but fix the brace/indent style
Comment 2 Dan Winship 2014-03-18 13:57:57 UTC 
Created attachment 272275 [details] [review]
gio: fix two more g_task_return_error_if_cancelled() leaks

----

I did a quick check if there were any more, and there were. But the
examples in the gtask.c docs get it right at least.
Comment 3 Olivier Crête 2014-03-23 14:58:13 UTC 
Created attachment 272688 [details] [review]
socketclient: Fix leak
Comment 4 Dan Winship 2014-03-23 19:00:30 UTC 
pushed both patches to master

Attachment 272275 [details] pushed as 1e8c4d2 - gio: fix two more g_task_return_error_if_cancelled() leaks
Attachment 272688 [details] pushed as 14872d2 - socketclient: Fix leak