After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726413 - Break out the sources dialog as a separate class / GtkBuilder template
Break out the sources dialog as a separate class / GtkBuilder template
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-15 13:56 UTC by Kalev Lember
Modified: 2014-04-07 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Break out the sources dialog as a separate object (80.25 KB, patch)
2014-03-15 13:57 UTC, Kalev Lember 		none Details | Review
sources dialog: Set headerbar as an internal child in the .ui file (6.39 KB, patch)
2014-03-15 13:57 UTC, Kalev Lember 		none Details | Review
sources dialog: Fade in the loading spinner (1.41 KB, patch)
2014-03-15 13:57 UTC, Kalev Lember 		none Details | Review

Description Kalev Lember 2014-03-15 13:56:29 UTC 
Might be too late for this cycle, not sure. Should get this in before the code freeze on Monday if it makes sense for 3.12.
Comment 1 Kalev Lember 2014-03-15 13:57:05 UTC 
Created attachment 272005 [details] [review]
Break out the sources dialog as a separate object

At the same time, move to a separate GtkBuilder template.
Comment 2 Kalev Lember 2014-03-15 13:57:09 UTC 
Created attachment 272006 [details] [review]
sources dialog: Set headerbar as an internal child in the .ui file
Comment 3 Kalev Lember 2014-03-15 13:57:12 UTC 
Created attachment 272007 [details] [review]
sources dialog: Fade in the loading spinner

This avoids briefly flickering the spinner when the loading time is fast
enough (which is the case with newer PK backends like Hawkey).