After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726362 - rtsp-stream: fix a typo where IPv4 and IPv6 addresses were confused.
rtsp-stream: fix a typo where IPv4 and IPv6 addresses were confused.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-14 18:30 UTC by Sebastian Rasmussen
Modified: 2014-03-15 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing IPV4 and IPV6 typos. (1.20 KB, patch)
2014-03-14 18:31 UTC, Sebastian Rasmussen 		none Details | Review
Proposed patch refraining from using double-pointers unnecessarily. (3.63 KB, patch)
2014-03-14 18:32 UTC, Sebastian Rasmussen 		none Details | Review
Proposed patch plugging leak of address object in RTSPStream. (3.27 KB, patch)
2014-03-14 18:32 UTC, Sebastian Rasmussen 		none Details | Review
Proposed patch fixing IPV4 and IPV6 typos. (1.20 KB, patch)
2014-03-15 12:05 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-03-14 18:30:18 UTC 
The primary change by this patch is plugging a memory leak when acquiring or reserving an address from the addresspool.

Another minor patch fixes a typo where IPv4 and IPv6 addresses were mixed.
These addresses seem to be an alternative to using an address pool, and so might better be removed..? What was the intent behind adding these to the RTSPStream? At least this patch makes the code make sense.

While fixing this problem the unnecessary use of double-pointers was removed.

Review and enjoy! :)
Comment 1 Sebastian Rasmussen 2014-03-14 18:31:39 UTC 
Created attachment 271937 [details] [review]
Proposed patch fixing IPV4 and IPV6 typos.
Comment 2 Sebastian Rasmussen 2014-03-14 18:32:16 UTC 
Created attachment 271938 [details] [review]
Proposed patch refraining from using double-pointers unnecessarily.
Comment 3 Sebastian Rasmussen 2014-03-14 18:32:46 UTC 
Created attachment 271939 [details] [review]
Proposed patch plugging leak of address object in RTSPStream.
Comment 4 Sebastian Rasmussen 2014-03-15 12:05:57 UTC 
Created attachment 271996 [details] [review]
Proposed patch fixing IPV4 and IPV6 typos.
Comment 5 Sebastian Rasmussen 2014-03-15 12:06:48 UTC 
After reading the code more closely it was obivous why the double-pointers and the missing free was indeed missing, sorry about the churn.
Comment 6 Sebastian Dröge (slomo) 2014-03-15 14:46:32 UTC 
commit 0b617dd5bd4311c863d37defd2e5b8c3949e861c
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Mar 14 19:03:24 2014 +0100

    rtsp-stream: Don't mix IPv4 and IPv6 addresses
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726362