GNOME Bugzilla – Bug 726361
vaapipostproc deinterlace-mode did not behave as you would expect
Last modified: 2014-06-18 14:26:10 UTC
vaapipostproc's deinterlace-mode only behaved as expected when set to disabled or when set to auto and using interlace-mode=mixed sources (such as vaapidecode). force and interlace-mode=interleaved didn't get deinterlaced properly, and a misflagged buffer in interlace-mode=progressive could get deinterlaced unexpectedly. I'll attach a patch to fix this to behave the same way as deinterlace elements do.
Created attachment 271936 [details] [review] [PATCH] postproc: Make deinterlace-mode behave as expected deinterlace-mode didn't behave in the way you'd expect if you have past experience of the deinterlace element. There were two bugs: 1. "auto" mode wouldn't deinterlace "interleaved" buffers, only "mixed". 2. "force" mode wouldn't deinterlace "mixed" buffers flagged as progressive. Fix these up, and add assertions and error messages to detect cases that aren't handled. Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk> --- gst/vaapi/gstvaapipostproc.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-)
OK, but I will move down the default: clause so that to make some compilers happy.
commit 927fd2e1a80018138b2d4ed51f75e43370234f68 Author: Simon Farnsworth <simon.farnsworth@onelan.co.uk> Date: Fri Mar 14 17:49:40 2014 +0000 vaapipostproc: make deinterlace-mode behave as expected. deinterlace-mode didn't behave in the way you'd expect if you have past experience of the deinterlace element. There were two bugs: 1. "auto" mode wouldn't deinterlace "interleaved" buffers, only "mixed". 2. "force" mode wouldn't deinterlace "mixed" buffers flagged as progressive. Fix these up, and add assertions and error messages to detect cases that aren't handled. https://bugzilla.gnome.org/show_bug.cgi?id=726361 Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk> Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>