Created attachment 271843 [details] [review]
stage-cogl: Fix feature check in clutter_stage_cogl_redraw

We do not strictly require COGL_WINSYS_FEATURE_SWAP_REGION to be able to do
clipped redraws they work with only COGL_WINSYS_FEATURE_BUFFER_AGE as well.

So fix the check to enable clipped redraws when we have either one of the
two features.

We do not strictly require COGL_WINSYS_FEATURE_SWAP_REGION to

(In reply to comment #0)
> See patch, just noticed it while reading through the code. While I don't know
> if there is any real case / driver where this causes clipped redraws not
> to work ... we should still be correct here.

Actually there is:

 /* The KMS winsys doesn't support swap region */
      vtable.onscreen_swap_region = NULL;

So this is required to make them work under wayland on top of KMS.

Created attachment 271844 [details] [review]
stage-cogl: Fix feature check in clutter_stage_cogl_redraw

We do not strictly require COGL_WINSYS_FEATURE_SWAP_REGION to be able to do
clipped redraws they work with only COGL_WINSYS_FEATURE_BUFFER_AGE as well.

So fix the check to enable clipped redraws when we have either one of the
two features.


Fix commit message.

Review of attachment 271844 [details] [review]:

the patch looks good to me.

the commit message is still a bit wonky; probably something like this:

'''
We do not strictly require the 'swap-region' Cogl feature in order to use clipped redraws: they work equally well with just the 'buffer-age' Cogl feature.
'''

Pushed with fixed commit message.

Attachment 271844 [details] pushed as 06387c3 - stage-cogl: Fix feature check in clutter_stage_cogl_redraw