After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726263 - authPrompt: Don't ever ask for a username if smartcard service is in foreground
authPrompt: Don't ever ask for a username if smartcard service is in foreground
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-13 17:46 UTC by Ray Strode [halfline]
Modified: 2014-03-13 19:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
authPrompt: Don't ever ask for a username if smartcard service is in foreground (3.15 KB, patch)
2014-03-13 17:46 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2014-03-13 17:46:07 UTC
The smartcard service is put in the foreground in two cases:

1) If password service is disabled by admin configuratoin
2) if a smartcard is inserted

In either case we don't want to ask the user to pick a user from the
userlist.  We currently only avoid asking in case 2.

This commit fixes case 1.
Comment 1 Ray Strode [halfline] 2014-03-13 17:46:09 UTC
Created attachment 271772 [details] [review]
authPrompt: Don't ever ask for a username if smartcard service is in foreground
Comment 2 Giovanni Campagna 2014-03-13 18:06:26 UTC
Review of attachment 271772 [details] [review]:

Looks right to me.
Comment 3 Ray Strode [halfline] 2014-03-13 19:08:28 UTC
Attachment 271772 [details] pushed as f6ed3d9 - authPrompt: Don't ever ask for a username if smartcard service is in foreground