After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726208 - gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS
gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
: 169960 697543 (view as bug list)
Depends on:
Blocks: 726012
 
 
Reported: 2014-03-12 23:40 UTC by Allison Karlitskaya (desrt)
Modified: 2015-01-26 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS (1.68 KB, patch)
2014-03-12 23:41 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
gnome-autogen.sh: correct IFS value (989 bytes, patch)
2014-03-12 23:56 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-03-12 23:40:54 UTC 
jhbuild has set this variable for more than two years (see bug 634617).  We finally want to drop setting ACLOCAL_FLAGS in jhbuild.
Comment 1 Allison Karlitskaya (desrt) 2014-03-12 23:41:17 UTC 
Created attachment 271666 [details] [review]
gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS

jhbuild has set this variable for more than two years.
Comment 2 Christian Persch 2014-03-12 23:55:17 UTC 
Comment on attachment 271666 [details] [review]
gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS

+    IFS="${IFS=         }"; save_IFS="$IFS"; IFS=":"

This is wrong; looks like a c&p problem where a tab + space was subsituted with 9 spaces.

With that fixed, ok to commit.
Comment 3 Allison Karlitskaya (desrt) 2014-03-12 23:56:39 UTC 
Created attachment 271668 [details] [review]
gnome-autogen.sh: correct IFS value

Due to a likely copy-paste mistake, the default value of IFS was being
set to 9 spaces instead of a tab and a space.  Fix that.
Comment 4 Allison Karlitskaya (desrt) 2014-03-12 23:57:27 UTC 
Attachment 271666 [details] pushed as 3360898 - gnome-common: use ACLOCAL_PATH over ACLOCAL_FLAGS
Attachment 271668 [details] pushed as fb0e5a9 - gnome-autogen.sh: correct IFS value
Comment 5 Javier Jardón (IRC: jjardon) 2014-03-13 14:02:26 UTC 
*** Bug 697543 has been marked as a duplicate of this bug. ***
Comment 6 Allison Karlitskaya (desrt) 2014-03-13 14:21:31 UTC 
*** Bug 169960 has been marked as a duplicate of this bug. ***
Comment 7 Colin Walters 2014-03-17 20:26:30 UTC 
This breaks at least gnome-doc-utils:

https://git.gnome.org/browse/gnome-doc-utils/tree/autogen.sh#n24

Can we:

1) Reopen this and use it as a tracker for things that need to be fixed
and/or:
2) *Also* read ACLOCAL_PATH?
Comment 8 Allison Karlitskaya (desrt) 2014-03-17 21:10:24 UTC 
I'm fine with 1.

I think people should get off of ACLOCAL_FLAGS, though, and we're never going to find these sorts of issues if we keep allowing its use.
Comment 9 Colin Walters 2014-03-17 21:32:18 UTC 
Ok, we need to do an audit of things which build-depend on gnome-common.
Comment 10 David King 2015-01-26 17:06:33 UTC 
gnome-doc-utils support has now been removed from gnome-common, and a future common autogen.sh is currently in the planning stages:

https://wiki.gnome.org/Projects/GnomeCommon/Migration