After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726111 - Specify runtime deps in README file
Specify runtime deps in README file
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-11 14:59 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added runtime dependencies section in README (1.48 KB, patch)
2014-03-11 14:59 UTC, Lasse Schuirmann 		needs-work Details | Review
Added runtime deps section in README (1.59 KB, patch)
2014-03-11 18:57 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-03-11 14:59:33 UTC 
If mcopy is not available and the user tries to express-install an iso, he will get a message, that this failed.

mtools (containing mcopy) is not listed as a dependency in the AUR package I use. I left a comment there.
Comment 1 Lasse Schuirmann 2014-03-11 14:59:35 UTC 
Created attachment 271526 [details] [review]
Added runtime dependencies section in README

This is nessecary since mcopy is needed for express installation at runtime.
Comment 2 Zeeshan Ali 2014-03-11 15:26:25 UTC 
Review of attachment 271526 [details] [review]:

dependencies -> deps in commit log to keep it short. Its fine to use shortforms and abbreviation as long as they are well-known.

::: README
@@ +37,3 @@
+====================
+
+* mcopy (usually provided with mtools)

with mtools -> by mtools pacakge

::: src/unattended-file.vala
@@ +14,3 @@
         debug ("Copying unattended file '%s' into disk drive/image '%s'", dest_name, installer.disk_file.get_path ());
         // FIXME: Perhaps we should use libarchive for this?
+        // make sure to also change the mcopy runtime dependency in README!

the other change in this patch makes this redundant, don't you think? :)
Comment 3 Lasse Schuirmann 2014-03-11 18:57:53 UTC 
Created attachment 271549 [details] [review]
Added runtime deps section in README

This is nessecary since mcopy is needed for express installation at runtime.
Comment 4 Zeeshan Ali 2014-03-11 19:13:48 UTC 
Review of attachment 271549 [details] [review]:

Reminder: Use present tense in commit log (especially summary) but no biggie, I'll modify before pushing..