After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726098 - sbcenc: Allow user to set channel-mode
sbcenc: Allow user to set channel-mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.2.3
Other Linux
: Normal minor
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-11 10:07 UTC by Aurélien Zanelli
Modified: 2014-03-12 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sbcenc: Allow user to set channel-mode (2.78 KB, patch)
2014-03-11 10:07 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2014-03-11 10:07:41 UTC
Created attachment 271511 [details] [review]
sbcenc: Allow user to set channel-mode

Currently, we can't set channel-mode to sbcenc.
Following pipeline resunt in negotiation error:
gst-launch audiotestsrc ! sbcenc ! audio/x-sbc,channels=2,channel-mode=stereo ! fakesink

Log is
gst_sbc_enc_set_format:<sbcenc0> fixating caps audio/x-sbc, rate=(int)44100, channels=(int)2, channel-mode=(string)stereo, blocks=(int){ 4, 8, 12, 16 }, subbands=(int){ 4, 8 }, allocation-method=(string){ snr, loudness }, bitpool=(int)[ 2, 64 ]
gst_sbc_enc_set_format:<sbcenc0> Failed to fixate channel-mode for 2 channels

I suggest to allow user to set channel mode and check if value is correlated with channels number and don't return error if value is already set.
Comment 1 Sebastian Dröge (slomo) 2014-03-12 08:06:56 UTC
commit da601be78f011f22fcedc0c5691ddf32a5eef63a
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Tue Mar 11 10:32:46 2014 +0100

    sbcenc: Allow user to set channel-mode
    
    Don't return error when channel-mode is already set, just check that it
    is coherent with number of channels.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726098