GNOME Bugzilla – Bug 725890
Miscellaneous memory fixes
Last modified: 2014-03-10 10:27:58 UTC
I received a downstream report about memory leaks found by running dfuzzer [1] against Tracker's services. This is an attempt to narrow them down and fix some of them. [1] https://github.com/matusmarhefka/dfuzzer
Created attachment 271204 [details] [review] libtracker-miner: Do not leak the TrackerSparqlConnection
Created attachment 271214 [details] [review] libtracker-fts: Free the list
Created attachment 271224 [details] [review] miner-fs: Do not leak the UpDevice
Comment on attachment 271204 [details] [review] libtracker-miner: Do not leak the TrackerSparqlConnection Looks good to me, please commit.
Comment on attachment 271224 [details] [review] miner-fs: Do not leak the UpDevice Looks good to me, please commit :)
Comment on attachment 271214 [details] [review] libtracker-fts: Free the list Looks good to me. I personally hate while() situations where for() is more appropriate ;) Other than that, I would have gone one further and used GSList* everywhere, less memory and we only need to traverse one way :) Anyway, thanks for the great patch, I saw this in Valgrind this week and wanted to find time to fix it!
Thanks for the reviews, Martyn. I do not have anything more at this point.