After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725642 - videodecoder: free bufferpool and allocator earlier
videodecoder: free bufferpool and allocator earlier
Status: RESOLVED DUPLICATE of bug 720389
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-04 06:54 UTC by Matthew Waters (ystreet00)
Modified: 2014-03-04 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videodecoder: free bufferpool and allocator earlier (1.72 KB, patch)
2014-03-04 06:55 UTC, Matthew Waters (ystreet00) 		needs-work Details | Review
videodecoder: free bufferpool and allocator earlier (1.72 KB, patch)
2014-03-04 09:07 UTC, Matthew Waters (ystreet00) 		none Details | Review

Description Matthew Waters (ystreet00) 2014-03-04 06:54:04 UTC 
There could be hardware resources inside the bufferpool/allocator that need to freed before close can be called.  One specific culmination of this is evident with https://bugzilla.gnome.org/show_bug.cgi?id=725048#c15
Comment 1 Matthew Waters (ystreet00) 2014-03-04 06:55:19 UTC 
Created attachment 270871 [details] [review]
videodecoder: free bufferpool and allocator earlier
Comment 2 Sebastian Dröge (slomo) 2014-03-04 08:49:14 UTC 
Comment on attachment 270871 [details] [review]
videodecoder: free bufferpool and allocator earlier

Can you also prepare the same patch for the video encoder, and audio encoder/decoder?
Comment 3 Sebastian Dröge (slomo) 2014-03-04 08:50:16 UTC 
Comment on attachment 270871 [details] [review]
videodecoder: free bufferpool and allocator earlier

Actually... this should be in PAUSED->READY state change already. And we need to make sure that before unreffing we deactivate the buffer pool.
Comment 4 Matthew Waters (ystreet00) 2014-03-04 09:07:05 UTC 
Created attachment 270877 [details] [review]
videodecoder: free bufferpool and allocator earlier

(In reply to comment #3)
> (From update of attachment 270871 [details] [review])
> Actually... this should be in PAUSED->READY state change already. And we need
> to make sure that before unreffing we deactivate the buffer pool.

Already?  It doesn't seem to be in the PAUSED->READY state change or any of the functions it calls.
Comment 5 Matthew Waters (ystreet00) 2014-03-04 09:10:04 UTC 
Ah, it's in master, not 1.2.
Comment 6 Matthew Waters (ystreet00) 2014-03-04 09:13:01 UTC 

*** This bug has been marked as a duplicate of bug 720389 ***