After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725635 - use AC_PATH_TOOL to find libgcrypt-config for better cross-compile and multilib support
use AC_PATH_TOOL to find libgcrypt-config for better cross-compile and multil...
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-04 05:28 UTC by Alexandre Rostovtsev
Modified: 2014-09-28 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.00 KB, patch)
2014-03-04 05:29 UTC, Alexandre Rostovtsev 		none Details | Review
2in1 patch for libgcrypt-config and xml2-config (1.66 KB, patch)
2014-09-03 09:52 UTC, Michał Górny 		none Details | Review

Description Alexandre Rostovtsev 2014-03-04 05:28:18 UTC 
Since libgcrypt-config is used to find host system libraries, libxslt's configure should be using AC_PATH_TOOL, not AC_PATH_PROG, to detect it.

AC_PATH_TOOL would first try to look for ${CHOST}-libgcrypt-config (e.g. i686-pc-linux-gnu-libgcrypt-config) before falling back to plain libgcrypt-config. This makes things much easier when cross-compiling or when building libxslt on a fully multilib system.
Comment 1 Alexandre Rostovtsev 2014-03-04 05:29:05 UTC 
Created attachment 270865 [details] [review]
proposed patch
Comment 2 Michał Górny 2014-03-04 07:08:01 UTC 
Just to be clear, I'd like to mention that it's the upstream-preferred way and it's used like that in libgcrypt.m4.
Comment 3 Michał Górny 2014-09-03 09:52:00 UTC 
Created attachment 285240 [details] [review]
2in1 patch for libgcrypt-config and xml2-config

The same applies to xml2-config.

Alexandre, could you update the bug summary to mention both?
Comment 4 Nick Wellnhofer 2014-09-28 14:19:03 UTC 
Applied the 2-in-1 patch:

https://git.gnome.org/browse/libxslt/commit/?id=8df3ccba4f1840eb8d11467e27c50d6018e932c5