After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725554 - xdmcp: unbreak build on OpenBSD
xdmcp: unbreak build on OpenBSD
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.10.x
Other OpenBSD
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-03 08:18 UTC by Antoine Jacoutot
Modified: 2014-03-03 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for ipv4->v6 definitions (1.99 KB, patch)
2014-03-03 08:18 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2014-03-03 08:18:29 UTC 
Created attachment 270760 [details] [review]
check for ipv4->v6 definitions

Hi.

OpenBSD has no support for IPv4 to IPv6 mapping, so make check for the
required definitions before using them.
Thank you.
Comment 1 Ray Strode [halfline] 2014-03-03 15:34:01 UTC 
Review of attachment 270760 [details] [review]:

This is probably okay and if you want to push it go ahead.
I have an alternative idea that you could try if you want, that might leave the code a little easier to read:

AC_DEFINE AI_V4MAPPED and AI_ALL to 0 if they are unavailable at configure time.
Comment 2 Antoine Jacoutot 2014-03-03 16:06:38 UTC 
> This is probably okay and if you want to push it go ahead.
> I have an alternative idea that you could try if you want, that might leave the
> code a little easier to read:
> 
> AC_DEFINE AI_V4MAPPED and AI_ALL to 0 if they are unavailable at configure
> time.

Thanks Ray. I committed it for the time being (it will help my jhbuild on OpenBSD WIP): 446d061

I have no clue how to check for existing pre-processor definitions with autoconf so I went the lazy way ;-)