After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725512 - The official symbol for Canadian dollar is "$", not "C$"
The official symbol for Canadian dollar is "$", not "C$"
Status: RESOLVED OBSOLETE
Product: GnuCash
Classification: Other
Component: Currency and Commodity
2.6.1
Other All
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on: 723145
Blocks:
 
 
Reported: 2014-03-02 18:56 UTC by Guillaume Pratte
Modified: 2018-06-29 23:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Canadian currency (822 bytes, patch)
2014-03-02 21:30 UTC, Guillaume Pratte
needs-work Details | Review

Description Guillaume Pratte 2014-03-02 18:56:05 UTC
The official symbol for Canadian dollar is "$", not "C$". "C$" should only be used to distinguish against other currencies.

Ref: https://en.wikipedia.org/wiki/Canadian_dollar

GnuCash 2.4.x was displaying Canadian dollar as "$", but this has changed with 2.6.x, where it is displayed as "C$". Canadian are accustomed to see their currency rendered as "$", so this is a major annoyance.

Enclosed is a proposed patch to src/engine/iso-4217-currencies.scm to restore the behavior of 2.4.x.

As a side note, in 2.4.x, GnuCash was able to distinguish USD from CAD by adding the ISO code in case of need, e.g. $USD. If this behavior is still present, properly representing CAD as "$" will cause no issues when mixing CAD and USD.
Comment 1 André Klapper 2014-03-02 20:50:37 UTC
Patch missing...
Comment 2 Guillaume Pratte 2014-03-02 21:30:08 UTC
Created attachment 270727 [details] [review]
Patch for Canadian currency
Comment 3 Geert Janssens 2014-03-10 19:17:18 UTC
Thank you for your patch. However I'm not sure this is the correct approach to fix this issue.

GnuCash 2.4 used the symbol returned by the system's locale. This part has been dropped in 2.6 and probably has to be restored.

If I understand correctly the iso-4217-currencies file holds internationalized currency symbols which should be used for currencies different from the locale currency.

Bug 723145 is all about this issue and getting it fixed. I have marked it as a depencency to get this issue resolved because both are obviously about the same issue.
Comment 4 Geert Janssens 2014-04-05 10:30:49 UTC
Comment on attachment 270727 [details] [review]
Patch for Canadian currency

I'm setting this patch to needs-work while waiting for bug 723145 to improve the implementation for user symbols. At that point this patch will either no longer be necessary or need adaptation.
Comment 5 John Ralls 2018-06-29 23:27:45 UTC
GnuCash bug tracking has moved to a new Bugzilla host. The new URL for this bug is https://bugs.gnucash.org/show_bug.cgi?id=725512. Please continue processing the bug there and please update any external references or bookmarks.