GNOME Bugzilla – Bug 725505
new syntax highlighting for code is weird
Last modified: 2014-03-06 12:44:32 UTC
I was looking at https://developer.gnome.org/gdk-pixbuf/unstable/gdk-pixbuf-File-saving.html#gdk-pixbuf-save and felt it harder than usual to read the code examples. In particular the icc profile example in that function confused me. I tried to figure out why and here's some uneducated guesses: - Using orange for parentheses and commas deemphasizes these symbols that bring structure too much. - Using orange for the * and & for pointers emphasizes them, potentially too much when they are the only colored symbol in a line like the first saying "gchar *contents;" - Using bold function names gives too much emphasis. It would be nicer to just color them differently. - The orange used for coloring symbols is too close in color to string highlighting. My eyes think the & from the error argument belongs to the "png" string in the "gdk_pixbuf_save (pixbuf, handle, "png", &error," line.
Haven't been any changes to the gtk-doc css for this recently I think. However, we are now using the gtk doc css on the webpage where we weren't before. The style is currently: https://git.gnome.org/browse/gtk-doc/tree/style/style.css#n296 The original style seems to come from: https://git.gnome.org/browse/gtk-doc/commit/?id=309b01ec I agree the coloring is over the top. In particular, the use of the symbol class. Let's see what we can do.
Created attachment 270850 [details] [review] Update the code listing style Something like this should help.
Thanks, looks nicer!
The following fix has been pushed: b4e00ad Update the code listing style
Created attachment 271097 [details] [review] Update the code listing style