After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725173 - Album artist sorting patch
Album artist sorting patch
Status: RESOLVED DUPLICATE of bug 678706
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-25 21:53 UTC by Wychopen II
Modified: 2015-03-19 22:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
album sorting patch (38.19 KB, patch)
2014-02-25 22:01 UTC, Wychopen II
none Details | Review

Description Wychopen II 2014-02-25 21:53:14 UTC
Hi,

I've put together this patch that adds the ability to sort your library by album artists. This adds a browser view as well as an extra column. Browsing by album artist is a necessity for library's with many compilation/guest albums as it can really be cluttered otherwise. This adds the minimal amount of code to get the job done and if I've missed something or if I need to correct something please note said problem and I'd be happy to fix it.

Here are two screenshots of the patch in use.
Take note of the columns in the playlist 

http://i.imgur.com/6vloNuw.png
http://i.imgur.com/cAy0BJu.png

I hope you consider this patch, thanks.
Comment 1 Wychopen II 2014-02-25 22:01:08 UTC
Created attachment 270330 [details] [review]
album sorting patch
Comment 2 Wychopen II 2014-02-27 01:30:43 UTC
This is a little silly. I apparently had missed https://bugzilla.gnome.org/show_bug.cgi?id=678706 because I would not have bothered with this patch otherwise. So why has this patch not been accepted yet? There's very clearly a demand as you would see if you did a quick google search but yet the feature is still lacking in 3.x.

Why? EVERY notable music player has this feature or has this set by default. Why is rhythmbox the only one without? xnoise, cantata, sonata, banshee, clementine, exaile, audacious, gmmpc, and so many others that I can't currently name off the top of my head. I don't think there has been a sufficient explanation... at all.

*** This bug has been marked as a duplicate of bug 678706 ***
Comment 3 Jonathan Matthew 2014-02-27 12:10:11 UTC
(In reply to comment #2)
> I don't think there has been a explanation... at all.

I don't owe you an explanation for anything.
Comment 4 Wychopen II 2014-02-27 12:27:17 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > I don't think there has been a explanation... at all.
> 
> I don't owe you an explanation for anything.

I may not be entitled to an explanation but I do think it's a fairly courteous thing to do. I also don't feel a passive aggressive comment is warranted.
Comment 5 Jonathan Matthew 2014-02-27 12:38:30 UTC
hilarious.
Comment 6 Jonathan Matthew 2014-02-27 12:59:35 UTC
So with that out of the way, here's the explanation: I don't like the current browser at all, so I'm not interested in bolting things on the side of it to make it even more complicated and annoying to deal with, which makes this a low priority feature request.
Comment 7 Ruud van Asseldonk 2014-03-20 15:44:12 UTC
(In reply to comment #6)
> I don't like the current browser at all

Do you mean from a code point of view, or from a usability point of view? In my opinion, usability would benefit from this change. It seems that [many users](https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/253167) would appreciate the feature as well.

If you are not satisfied with the current state of the code, how can we help to improve it?
Comment 8 saw.sma 2015-03-19 22:09:23 UTC
(In reply to Wychopen II from comment #2)
> Why? EVERY notable music player has this feature or has this set by default.
> Why is rhythmbox the only one without? xnoise, cantata, sonata, banshee,
> clementine, exaile, audacious, gmmpc, and so many others that I can't
> currently name off the top of my head. I don't think there has been a
> sufficient explanation... at all.

Yeah, it is kind of essential for any serious music player, it has been thus for years.

(In reply to Jonathan Matthew from comment #6)
> So with that out of the way, here's the explanation: I don't like the
> current browser at all, so I'm not interested in bolting things on the side
> of it to make it even more complicated and annoying to deal with, which
> makes this a low priority feature request.

Not sure how the fact that you don’t ‘like’ the current browser makes this a low priority feature. As numerous people have been saying for years this is a pretty essential feature, hence why it’s available (or set by default) on most decent music players. There’s no denying that, whether you like it or not is irrelevant.