After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725064 - Don't crash when leaving a room without a channel
Don't crash when leaving a room without a channel
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-24 14:18 UTC by Giovanni Campagna
Modified: 2014-02-24 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't crash when leaving a room without a channel (1.62 KB, patch)
2014-02-24 14:18 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-24 14:18:02 UTC 
If the channel disappears, for example because we were disconnected
and it was not restored, just remove the room from our data
structures.
Comment 1 Giovanni Campagna 2014-02-24 14:18:05 UTC 
Created attachment 270134 [details] [review]
Don't crash when leaving a room without a channel
Comment 2 Florian Müllner 2014-02-24 14:27:09 UTC 
Review of attachment 270134 [details] [review]:

::: src/application.js
@@ +393,3 @@
             if (!message.length)
                 message = _("Good Bye"); // TODO - our first setting?
+            if (room.channel) {

Just move this above to the else part:

} else if (room.channel) {
Comment 3 Giovanni Campagna 2014-02-24 15:06:47 UTC 
Pushed with suggested change.
Attachment 270134 [details] pushed as d96c6fb - Don't crash when leaving a room without a channel