GNOME Bugzilla – Bug 724902
User list remains disabled when room becomes connected
Last modified: 2014-02-21 16:52:22 UTC
Since bug 710271 rooms are shown before they are connected (e.g. have an associated channel), but we only update the user list button on room changes. As a result, the button stays disabled until switching away and back - ugh.
Created attachment 269929 [details] [review] chatroomManager: Add 'active-state-changed' signal In some places we care about the active room's status more than about the room itself (e.g. whether the active room currently has an associated channel or not). To track this, we'd have to first listen for room changes and then track the room's channel property - this is fairly cumbersome in most places, while trivial from ChatroomManager where we are already tracking all rooms anywhere, so add a new signal there.
Created attachment 269930 [details] [review] application: Use new signal to enable/disable user list Since the availability of the user list now also depends on the active room's channel property, updating on room changes is not enough. Use the new ChatroomManager::active-state-changed signal instead.
Attachment 269929 [details] pushed as 3377ca0 - chatroomManager: Add 'active-state-changed' signal Attachment 269930 [details] pushed as d647b58 - application: Use new signal to enable/disable user list