After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724837 - Handle --version command line option
Handle --version command line option
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-20 21:59 UTC by Paolo Borelli
Modified: 2014-02-21 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.85 KB, patch)
2014-02-20 22:00 UTC, Paolo Borelli
needs-work Details | Review
patch (2.40 KB, patch)
2014-02-21 20:35 UTC, Paolo Borelli
committed Details | Review

Description Paolo Borelli 2014-02-20 21:59:58 UTC
see patch
Comment 1 Paolo Borelli 2014-02-20 22:00:41 UTC
Created attachment 269843 [details] [review]
patch
Comment 2 David King 2014-02-21 17:06:04 UTC
Review of attachment 269843 [details] [review]:

::: src/gl-application.c
@@ +220,3 @@
+static const GOptionEntry options[] =
+{
+    { "version", 'v', 0, G_OPTION_ARG_NONE, NULL, N_("Print version information and exit"), NULL },

Is this more than 79 characters in length? Also, it's string change announcement period, so this will need an email to both gnome-i18n and gnome-doc-list.

@@ +221,3 @@
+{
+    { "version", 'v', 0, G_OPTION_ARG_NONE, NULL, N_("Print version information and exit"), NULL },
+    { NULL}

Missing a space after NULL.

@@ +261,3 @@
     priv->desktop = g_settings_new (DESKTOP_SCHEMA);
 
+    g_application_add_main_option_entries (G_APPLICATION (application), options);

As this was added to GIO only recently, it needs a corresponding bump to the dependency in configure.ac.
Comment 3 Paolo Borelli 2014-02-21 20:35:28 UTC
Created attachment 269949 [details] [review]
patch

I can send the i18n mail when committing
Comment 4 David King 2014-02-21 21:09:19 UTC
Comment on attachment 269949 [details] [review]
patch

Looks great, please go ahead!
Comment 5 Paolo Borelli 2014-02-21 23:09:43 UTC
pushed and mail sent to i18n and docs