GNOME Bugzilla – Bug 724615
flickr: Set mime-type for images
Last modified: 2014-02-18 11:39:52 UTC
.
Created attachment 269517 [details] [review] flickr: Set mime-type for images
*** Bug 724614 has been marked as a duplicate of this bug. ***
Review of attachment 269517 [details] [review]: I think you should add GRL_METADATA_KEY_MIME to the list of supported_keys. ::: src/flickr/grl-flickr.c @@ +489,3 @@ + g_free (mime); + } + } Need to free content_type too, and it can not be const gchar *.
Review of attachment 269517 [details] [review]: ::: src/flickr/grl-flickr.c @@ +484,3 @@ + + content_type = g_content_type_guess (url, NULL, 0, NULL); + mime = g_content_type_get_mime_type (content_type); You need to check if content_type is non-NULL. Else you will get a WARNING.
Created attachment 269519 [details] [review] flickr: Set MIME-type for media
Review of attachment 269519 [details] [review]: Looks good.
Attachment 269519 [details] pushed as c2ceb92 - flickr: Set MIME-type for media