After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724547 - network: allow selecting a specific VPN or virtual interface
network: allow selecting a specific VPN or virtual interface
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 724545 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-17 14:03 UTC by Giovanni Campagna
Modified: 2014-02-17 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: allow selecting a specific VPN or virtual interface (3.05 KB, patch)
2014-02-17 14:03 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
network: allow selecting a specific VPN or virtual interface (2.75 KB, patch)
2014-02-17 20:01 UTC, Giovanni Campagna 		committed Details | Review
network: handle argv after cold-plugging connections (1006 bytes, patch)
2014-02-17 20:01 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-17 14:03:00 UTC 
Overload the show-device operation to accept paths to NMConnections,
which can be matched to VPN connections or unadopted virtual
interfaces.
This will be used by gnome-shell to implement the VPN Settings
menu item.
Comment 1 Giovanni Campagna 2014-02-17 14:03:03 UTC 
Created attachment 269400 [details] [review]
network: allow selecting a specific VPN or virtual interface
Comment 2 Bastien Nocera 2014-02-17 17:15:15 UTC 
*** Bug 724545 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2014-02-17 17:16:42 UTC 
Review of attachment 269400 [details] [review]:

I'd do the notify_connections_read_cb() section of the patch in a separate commit. Looks good otherwise.
Comment 4 Giovanni Campagna 2014-02-17 20:01:39 UTC 
Created attachment 269465 [details] [review]
network: allow selecting a specific VPN or virtual interface

Overload the show-device operation to accept paths to NMConnections,
which can be matched to VPN connections or unadopted virtual
interfaces.
This will be used by gnome-shell to implement the VPN Settings
menu item.
Comment 5 Giovanni Campagna 2014-02-17 20:01:45 UTC 
Created attachment 269466 [details] [review]
network: handle argv after cold-plugging connections

To pick up show-device with a connection path (VPN or virtual),
we need to handle the arguments again after the connections are
read.
Comment 6 Giovanni Campagna 2014-02-17 20:02:35 UTC 
Attachment 269465 [details] pushed as 10ffa30 - network: allow selecting a specific VPN or virtual interface
Attachment 269466 [details] pushed as 741f09f - network: handle argv after cold-plugging connections