GNOME Bugzilla – Bug 724503
Make gtk_popover_bind_model() public
Last modified: 2014-02-21 08:59:02 UTC
Created attachment 269331 [details] [review] Make gtk_popover_bind_model public We are trying to wrap gtk_popover_new_from_model() in gtkmm, and having access to gtk_popover_bind_model() is the missing piece to finish wrapping this new constructor. Please note that this is a really-nice-to-have. In GtkMenuShell there is a public gtk_menu_shell_bind_model() method, and the *_new_from_model constructors of GtkMenuShell and derived classes seem to be equivalent to GtkPopover's. In the attached patch I've almost carbon-copied gtk_menu_shell_bind_model()'s documentation. So in case this seems a good idea, please feel free to modify the documentation as your will, or maybe it would be easier to not apply the patch and modify the source directly.
Created attachment 269332 [details] [review] Make gtk_popover_bind_model public Added more documentation.
Created attachment 269470 [details] [review] Fix gtk_popover_bind_model documentation model parameter cannot be NULL, as erroneously is stated in the documentation.
Sorry, now I realise model parameter *can* be NULL. Unfortunately I think I cannot remove the latest patch.
Comment on attachment 269470 [details] [review] Fix gtk_popover_bind_model documentation I've set this to rejected because the author thinks it is wrong/unnecessary now.