After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724472 - window: Don't crash when someone tries to run a native app using old gtk
window: Don't crash when someone tries to run a native app using old gtk
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-16 11:06 UTC by drago01
Modified: 2014-02-16 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Don't crash when someone tries to run a native app using old gtk (1.14 KB, patch)
2014-02-16 11:06 UTC, drago01 		committed Details | Review

Description drago01 2014-02-16 11:06:08 UTC 
Noticed yesterday when I forgot to do "jhbuild run" while testing native
wayland apps.
Comment 1 drago01 2014-02-16 11:06:10 UTC 
Created attachment 269290 [details] [review]
window: Don't crash when someone tries to run a native app using old gtk

This ends up calling meta_window_set_gtk_dbus_properties with a NULL
window, instead of segfaulting the compositor return so that the broken
app dies instead.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-16 14:50:18 UTC 
Review of attachment 269290 [details] [review]:

This should be in meta-wayland-surface.c
Comment 3 drago01 2014-02-16 15:20:08 UTC 
Pushed with suggested change.