After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724293 - Magnifier: fix a warning when calling setActive() with the same value
Magnifier: fix a warning when calling setActive() with the same value
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-13 14:14 UTC by Giovanni Campagna
Modified: 2014-02-13 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Magnifier: fix a warning when calling setActive() with the same value (1.66 KB, patch)
2014-02-13 14:14 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2014-02-13 14:14:11 UTC
We must not call enable/disable_unredirect if we didn't change the
active value, otherwise mutter gets confused and emits warnings.
Comment 1 Giovanni Campagna 2014-02-13 14:14:14 UTC
Created attachment 269013 [details] [review]
Magnifier: fix a warning when calling setActive() with the same value
Comment 2 drago01 2014-02-13 18:22:23 UTC
Review of attachment 269013 [details] [review]:

OK.
Comment 3 Giovanni Campagna 2014-02-13 18:44:12 UTC
Attachment 269013 [details] pushed as 3b01976 - Magnifier: fix a warning when calling setActive() with the same value