After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724292 - Fix a critical when processing deferred messages
Fix a critical when processing deferred messages
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-13 14:08 UTC by Giovanni Campagna
Modified: 2014-03-17 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix a critical when processing deferred messages (2.37 KB, patch)
2014-02-13 14:08 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-13 14:08:08 UTC 
Due to GMainContext manipulations and reentrancy issues, it's
possible the source pointer is NULL inside the callback.
Let's avoid the critical warning by unreffing the source early
- it is kept alive by GMainContext anyway after the attach.
Comment 1 Giovanni Campagna 2014-02-13 14:08:10 UTC 
Created attachment 269012 [details] [review]
Fix a critical when processing deferred messages
Comment 2 Mike Gorse 2014-03-17 15:51:05 UTC 
Comment on attachment 269012 [details] [review]
Fix a critical when processing deferred messages

Committed to master as 733120. (Actually committed this a while ago and never closed the bug.) Thanks for the patch.