After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724267 - When there are clips with a duration of 0 on the timeline, rendering may hang and get corrupt
When there are clips with a duration of 0 on the timeline, rendering may hang...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Rendering
Git
Other Linux
: Normal critical
: 0.95
Assigned To: Mathieu Duponchelle
Pitivi maintainers
: 732574 (view as bug list)
Depends on: 724571
Blocks:
 
 
Reported: 2014-02-13 03:28 UTC by John (J5) Palmieri
Modified: 2015-07-09 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description John (J5) Palmieri 2014-02-13 03:28:29 UTC
I have a tar of my project with low res clips that reproduces the errors I have been seeing while rendering my full res version.  You can download it at: 

https://drive.google.com/uc?id=0Bz5N1ZmJZP_tM0t0em5jQkxFREE&export=download

First issue is sometimes during transitions the rendering gets stuck and the estimated time starts going up drastically.  If I cancel and restart it usually gets through.  Sometimes I have to restart a number of times.

The more serious issue is that while the rendering video can be played back during the rendering process at some point the file gets corrupt and no longer is viewable even after the rendering finishes.  I suspect this is happening around the 7m30s mark because if you delete most of the tracks except the last few minutes and drag them to the start, the timeline still thinks the movie is 7m30s long.  I suspect there may be an ghost clip/image somewhere around there because I remember placing images on the timeline that I didn't stretch and they disappeared when I clicked on another element.

I'm rendering to webm/Vp8/Vorbis and resolution doesn't seem to effect anything.
Comment 1 John (J5) Palmieri 2014-02-13 03:30:03 UTC
I should note that the corruption happens 100% of the time.  I haven't been able to pinpoint when exactly it happens because the rendering takes 3+ hours and I tend to just come back to check on it from time to time.
Comment 2 Mathieu Duponchelle 2014-02-15 17:13:08 UTC
Hi, thanks for your feedback !

I'm having a look at the first issue right now, sharing what I have already.

I have managed to simplify your project to this:

http://paste.fedoraproject.org/77566/92483987

Here, one time out of four using ges-launch-1.0 -l /path/to/project -o file:///path/to/output/uri , I manage to reproduce a hang, and get a rather simple backtrace:




Comment 3 Mathieu Duponchelle 2014-02-17 20:19:24 UTC
This bug is related to https://bugzilla.gnome.org/show_bug.cgi?id=724571
Comment 4 Mathieu Duponchelle 2014-02-26 03:49:26 UTC
Hi John, I hoped to get back to you sooner but with the launch of our fundraising campaign I've been a little overwhelmed as of late. Just getting back to you I've investigated and devised fixes for the rendering issues exhibited by your project, and been able to render that like one week ago:

https://www.youtube.com/watch?v=rH5un9NtgKc

I've fixed the hangs, found out why the rendering became corrupt around 7:30 (look for clips with duration 0 at that point in your project, I recommend editing the xges directly), and additionnally also fixed an issue with sound being skipped for 30 seconds around 2-3 minutes iirc.

I however need time to clean up my patches and get them merged, I apologize for the delay.

Thanks for your donation, much appreciated!
Comment 5 John (J5) Palmieri 2014-03-16 20:04:40 UTC
Hey,

Thanks for fixing this.  Sorry, I've been busy so haven't been playing with it much but I wanted to thank you and the team for dedicating yourselves to such a massive project.  The blog is being outlined as we speak so hopefully I'll have some real content to show off pitivi in the future.

--
J5
Comment 6 Mathieu Duponchelle 2014-04-08 12:26:16 UTC
Hello, I have finally pushed the fix to the next-to-last remaining problem, missing audio during 30 seconds with that project.

You can now render that example project using pitivi, under the condition that you remove the clips with duration 0 in the xges file.

I'll leave this bug open for that specific problem.

I hope Pitivi can prove useful for your blog project, make sure to come discuss with us on the IRC about it, even if you don't have any more problems :)

You can get the daily builds of pitivi here : http://fundraiser.pitivi.org/download-bundles , once the update date indicated for the daily build is superior to the date and time of that comment, the last fix will be included :)

Cheers!
Comment 7 Thibault Saunier 2014-07-07 09:17:16 UTC
*** Bug 732574 has been marked as a duplicate of this bug. ***
Comment 8 Thibault Saunier 2015-07-09 08:01:36 UTC
commit 50f26f1269f33bad81024bbd0be8a7055167c3a0
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Wed Jul 8 18:59:33 2015 +0200

    nleobject: Concider objects as 'inactive' when they have a duration == 0


Also the gtktimeline make the 0 duration clips visible and useable so no problem anymore here.