After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724100 - error: unknown type name 'gst_ks_clock'
error: unknown type name 'gst_ks_clock'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal critical
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-11 06:36 UTC by Kyle
Modified: 2014-02-16 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
compile log (967.93 KB, application/octet-stream)
2014-02-12 06:54 UTC, Kyle
  Details
fetch log (790 bytes, application/octet-stream)
2014-02-12 06:54 UTC, Kyle
  Details
Patch to disable unported winks/directshow plugin (942 bytes, patch)
2014-02-15 02:00 UTC, Michael Sheldon
rejected Details | Review

Description Kyle 2014-02-11 06:36:54 UTC
I'm getting this error when trying to compile the latest gst-plugins-bad from git using cerbero:
gstksclock.c:54:30: error: unknown type name 'gst_ks_clock'
gstksclock.c:54:53: error: expected declaration specifiers or '...' before '(' token
gstksclock.c: In function 'gst_ks_clock_init':
gstksclock.c:82:3: warning: implicit declaration of function 'g_mutex_new' [-Wimplicit-function-declaration]
gstksclock.c:82:3: warning: nested extern declaration of 'g_mutex_new' [-Wnested-externs]
gstksclock.c:82:15: warning: assignment makes pointer from integer without a cast [enabled by default]
gstksclock.c:83:3: warning: implicit declaration of function 'g_cond_new' [-Wimplicit-function-declaration]
gstksclock.c:83:3: warning: nested extern declaration of 'g_cond_new' [-Wnested-externs]
gstksclock.c:83:21: warning: assignment makes pointer from integer without a cast [enabled by default]
gstksclock.c:84:21: warning: assignment makes pointer from integer without a cast [enabled by default]
gstksclock.c: In function 'gst_ks_clock_dispose':
gstksclock.c:104:3: error: 'parent_class' undeclared (first use in this function)
gstksclock.c:104:3: note: each undeclared identifier is reported only once for each function it appears in
gstksclock.c: In function 'gst_ks_clock_finalize':
gstksclock.c:113:3: warning: implicit declaration of function 'g_cond_free' [-Wimplicit-function-declaration]
gstksclock.c:113:3: warning: nested extern declaration of 'g_cond_free' [-Wnested-externs]
gstksclock.c:115:3: warning: implicit declaration of function 'g_mutex_free' [-Wimplicit-function-declaration]
gstksclock.c:115:3: warning: nested extern declaration of 'g_mutex_free' [-Wnested-externs]
gstksclock.c:117:3: error: 'parent_class' undeclared (first use in this function)
gstksclock.c: In function 'gst_ks_clock_start':
gstksclock.c:332:9: warning: implicit declaration of function 'g_thread_create' [-Wimplicit-function-declaration]
gstksclock.c:332:9: warning: nested extern declaration of 'g_thread_create' [-Wnested-externs]
gstksclock.c:331:25: warning: assignment makes pointer from integer without a cast [enabled by default]
gstksclock.c: At top level:
gstksclock.c:57:1: warning: 'gst_ks_clock_base_init' defined but not used [-Wunused-function]
gstksclock.c:62:1: warning: 'gst_ks_clock_class_init' defined but not used [-Wunused-function]
gstksclock.c:73:1: warning: 'gst_ks_clock_init' defined but not used [-Wunused-function]
make[3]: *** [libgstwinks_la-gstksclock.lo] Error 1

This bug was not present yesterday, and the only file that seemed to have changed in sys/winks was Makefile.am (http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/sys/winks?id=ad92dfc7b4d6fde46cda3b65a925d18608b4258e). Rolling back that commit did not fix this issue.
Comment 1 Sebastian Dröge (slomo) 2014-02-11 08:21:46 UTC
See bug #702041 for porting the plugin. Let's properly disable it for now.

commit eef356c80f2eef7bbdc78a9930083cb940a632b3
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Feb 11 09:20:45 2014 +0100

    configure: The winks plugin is not ported to 1.0 yet
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724100
Comment 2 Kyle 2014-02-12 06:54:17 UTC
Created attachment 268882 [details]
compile log
Comment 3 Kyle 2014-02-12 06:54:36 UTC
Created attachment 268883 [details]
fetch log
Comment 4 Kyle 2014-02-12 06:55:15 UTC
It looks like that commit didn't fix it.

I'm using f3464e0 and still get the same error.

I've attached both the *-fetch and *-compile cerbero logs.
Comment 5 Michael Sheldon 2014-02-15 02:00:44 UTC
I think it should be "directshow" that's marked as being non-ported rather than "winks" as that's what the later sections check for. Patch attached.
Comment 6 Michael Sheldon 2014-02-15 02:00:52 UTC
Created attachment 269160 [details] [review]
Patch to disable unported winks/directshow plugin
Comment 7 Sebastian Dröge (slomo) 2014-02-16 09:10:33 UTC
To prevent such mistakes in the future... thanks Michael for noticing this.


commit 22b4223c86d5e996aa6a9df3d6b7f4ba56d572a8
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sun Feb 16 10:09:18 2014 +0100

    configure: Rename all variables related to the winks plugin
    
    It does not make sense to call them after directshow if they
    are for the winks plugin only.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724100