GNOME Bugzilla – Bug 724028
Icons for recent/favourite in entrycompletion
Last modified: 2015-08-17 12:15:30 UTC
So, what icons should we use? Do we need new ones? In GNOME right now we have 'document-open-recent' and 'document-open-recent-symbolic', of which I think the symbolic one looks nicer. And we also have 'starred' and 'non-starred' and also the symbolic forms. I tried taking some screenshots but when I press print-screen the completion-popup disappears :) Will append a patch with the symbolic and the non-symbolic versions of the icons mentioned above. In order to see the favorite one you need to edit the ~/.local/share/maps-places.json file and change a type: 0 to a type: 1, since we can't add favorites yet.
Created attachment 268666 [details] [review] Icons for entrycompletion
Created attachment 268667 [details] [review] Icons for entrycompletion, symbollic
So either use these, or create our own. What do you think?
(In reply to comment #3) > So either use these, or create our own. What do you think? screenshots will help better than patches to compare in this case. :)
(In reply to comment #4) > (In reply to comment #3) > > So either use these, or create our own. What do you think? > > screenshots will help better than patches to compare in this case. :) Agreed, can you tell me a way to take screenshots? If I press anything the dropdownbox will dissapear. I guess I could take a picture with my phone :)
Ok, I will do a mockup by adding them to the searchPopup so you can see what they look like.
Created attachment 268900 [details] non-symbolic
Created attachment 268901 [details] symbolic
(In reply to comment #7) > Created an attachment (id=268900) [details] > non-symbolic Meh, that looks like this very ugly DE that I don't want to mention by name. :) Symbolic is the outright winner I think.
Having said that, I'm not at all sure we want to show an icon for 'recent'. How about just 'favorite'.
If we are talking about the search-popup I agree, and I'm not really sure we even should show favorites there. But in the EntryCompletion my thinking was that it would be nice to show recent/favorite icons as a hint to users. To avoid giving the impression that it is completing on server-side search results.
(In reply to comment #11) > If we are talking about the search-popup I agree, and I'm not really sure we > even should show favorites there. > > But in the EntryCompletion my thinking was that it would be nice to show > recent/favorite icons as a hint to users. To avoid giving the impression that > it is completing on server-side search results. I don't see why user should care, really if its client or server-side. IMHO showing the favorite icon makes sense though.
Created attachment 270694 [details] [review] searchPopup: move treeview creation to ui file
Created attachment 270695 [details] [review] placeStore: Make exists method public
Created attachment 270696 [details] [review] Add favorite icon to search popover
Created attachment 270697 [details] [review] Add favorite icon to search completion