After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724006 - pango_ot_info_get() should checks NULL for argument
pango_ot_info_get() should checks NULL for argument
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.36.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-10 08:50 UTC by Akira TAGOH
Modified: 2014-02-13 03:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (732 bytes, patch)
2014-02-12 09:47 UTC, Akira TAGOH 		none Details | Review

Description Akira TAGOH 2014-02-10 08:50:27 UTC 
Originally reported at https://bugzilla.redhat.com/show_bug.cgi?id=1053798

That looks like not checking NULL for the return value of pango_fc_font_lock_face() is a fault in gimp though, assuming giving a valid pointer to pango_ot_info_get() sounds not good to me because it is a public API and pango itself can't ensure it is.
Comment 1 Akira TAGOH 2014-02-12 09:47:10 UTC 
Created attachment 268892 [details] [review]
proposed patch
Comment 2 Behdad Esfahbod 2014-02-12 19:50:24 UTC 
LGTM.  Can you push?
Comment 3 Akira TAGOH 2014-02-13 03:08:05 UTC 
Thanks. done.