GNOME Bugzilla – Bug 723895
Move search widget logic from MainWindow
Last modified: 2014-03-06 12:37:31 UTC
We need to refactor a bit. To enable the use of PlaceStore for completion and SearchPopup for displaying search results from other places than mainWindow. For instance in the sidebar for routing.
Created attachment 268488 [details] [review] Move search result model knowledge to SearchPopup This allows easy use of the SearchPopup from more places than mainwindow.
Created attachment 268489 [details] [review] Move completion match function to PlaceStore This enables the use of the PlaceStore for entry completion in more places than MainWindow.
Review of attachment 268488 [details] [review]: Great work, thanks! ::: src/searchPopup.js @@ +30,3 @@ + ICON: 0, + DESCRIPTION: 1, + PLACE: 2 Should this be in a separate patch?
Review of attachment 268489 [details] [review]: Looks good.
Review of attachment 268488 [details] [review]: ::: src/searchPopup.js @@ +30,3 @@ + ICON: 0, + DESCRIPTION: 1, + PLACE: 2 Hmm, I don't think so. Before this patch the SearchPopup only needed to know about icon and text, because it created a cellTextRenderer and a cellPixbufRenderer. With the moving of the adding logic from mainWindow to here, it needs to know more and it need to know that the text is a description. So I think it makes sense to have the change in this patch.
Zeeshan: any comments on these?
(In reply to comment #6) > Zeeshan: any comments on these? Havent checked the patch but I'm usually happy about refactoring of this sort. :)
Think it could go in now? Would like to base some other patches on these.
Attachment 268488 [details] pushed as 7b13078 - Move search result model knowledge to SearchPopup Attachment 268489 [details] pushed as 61b5379 - Move completion match function to PlaceStore