GNOME Bugzilla – Bug 723833
Strong shadows in Lo(gin)ckscreen
Last modified: 2014-02-07 16:23:31 UTC
This was bothering me for a while. I think that the shadows under the username and inside the field (it looks a lot worse when the field is selected, taking a screensshot deselcts it unfortunately) are a little bit too strong.
Created attachment 268391 [details] screenshot
Probably correct. What to try a theme patch? Should be pretty simple.
Okay, on it.
Created attachment 268408 [details] [review] Fix username's shadow
But it seems like I have found a problem (not sure since I can't inspect and didn't restart GDM) but there is not shadow for the username in the Login screen. and the user list item has the same intense shadow but there is no way I could find to control it!
Created attachment 268409 [details] After
Review of attachment 268408 [details] [review]: "fix" is a strong word for something that's not technically broken (there *is* a shadow after all, it's just being adjusted to look nicer), but OK ... Good to go after design team blessing. ::: data/theme/gnome-shell.css @@ +2504,3 @@ } .user-widget-label { There's no point in leaving the empty selector around.
@Florian the _look_ looks broken though. :P
Slightly off topic, Allan, maybe an "every detail matters" goal for the shadows in the theme? The text fields as well as the sub-menus all have strong-ish shadow that doesn't look great. :\
(In reply to comment #6) > Created an attachment (id=268409) [details] > After LGTM (In reply to comment #9) > Slightly off topic, Allan, maybe an "every detail matters" goal for the shadows > in the theme? The text fields as well as the sub-menus all have strong-ish > shadow that doesn't look great. :\ I'd be happy to take patches for those! :)
(In reply to comment #10) > (In reply to comment #6) > > Created an attachment (id=268409) [details] [details] > > After > > LGTM ... which makes the patch accepted-commit-new - do you have push access?
Comment on attachment 268408 [details] [review] Fix username's shadow Pushed: https://git.gnome.org/browse/gnome-shell/commit/?id=92ae26bb9fd6136bc14a38814a84efdbe5d2c516 Thanks Reda!