GNOME Bugzilla – Bug 723803
Use Header Bars
Last modified: 2014-02-08 23:43:04 UTC
Here are some patches to enable using header bars in dialogs.
Created attachment 268349 [details] [review] Use header bar for create web app dialog
Created attachment 268350 [details] [review] Use header bar on history dialog
Created attachment 268351 [details] [review] Use header bar on encodings dialog
Created attachment 268352 [details] [review] Use header bar on preferences dialog
Created attachment 268353 [details] [review] Make confirmation dialog modal
Created attachment 268354 [details] [review] Use header bar on cookies dialog
Created attachment 268355 [details] [review] Use header bar on passwords dialog
Created attachment 268356 [details] [review] Use header bar in clear personal data dialog
Created attachment 268357 [details] [review] Use header bar in certificate dialog
Created attachment 268358 [details] [review] Always make message dialogs modal
Created attachment 268359 [details] [review] Use header bar for bookmark properties dialog
Review of attachment 268350 [details] [review]: ::: src/resources/history-dialog.ui @@ +36,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center.
Review of attachment 268354 [details] [review]: ::: src/resources/cookies-dialog.ui @@ +36,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center.
Review of attachment 268355 [details] [review]: ::: src/resources/passwords-dialog.ui @@ +46,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center.
Review of attachment 268356 [details] [review]: ::: src/resources/clear-data-dialog.ui @@ +23,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center. Maybe to add also the "destructive-action" style? @@ +36,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center.
Review of attachment 268349 [details] [review]: OK
Created attachment 268422 [details] [review] Use header bar on history dialog
Created attachment 268423 [details] [review] Use header bar on encodings dialog
Created attachment 268424 [details] [review] Use header bar on preferences dialog
Created attachment 268425 [details] [review] Make confirmation dialog modal
Created attachment 268426 [details] [review] Use header bar on cookies dialog
Created attachment 268427 [details] [review] Use header bar on passwords dialog
Created attachment 268428 [details] [review] Use header bar in clear personal data dialog
Created attachment 268429 [details] [review] Use header bar in certificate dialog
Created attachment 268430 [details] [review] Always make message dialogs modal
Created attachment 268431 [details] [review] Use header bar for bookmark properties dialog
Review of attachment 268428 [details] [review]: ::: src/resources/clear-data-dialog.ui @@ +41,3 @@ + <property name="can_default">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> Please, add the style "text-button" and set the property valign to center, in another patch.