After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723697 - ostbuild: don't run main.js as a command line script
ostbuild: don't run main.js as a command line script
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-05 17:11 UTC by Giovanni Campagna
Modified: 2014-04-21 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ostbuild: don't run main.js as a command line script (2.82 KB, patch)
2014-02-05 17:11 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-05 17:11:30 UTC 
Variables defined there otherwise poison the global object
instead of a private module object.
Comment 1 Giovanni Campagna 2014-02-05 17:11:33 UTC 
Created attachment 268188 [details] [review]
ostbuild: don't run main.js as a command line script
Comment 2 Colin Walters 2014-04-21 21:22:05 UTC 
Review of attachment 268188 [details] [review]:

Looks fine.
Comment 3 Colin Walters 2014-04-21 21:22:24 UTC 
Attachment 268188 [details] pushed as 08d0531 - ostbuild: don't run main.js as a command line script