GNOME Bugzilla – Bug 723693
Two window list improvements
Last modified: 2015-03-02 21:23:16 UTC
See patches. Note: the overview animation patch is kinda buggy wrt event handling, but I don't know how to fix it, short of recursively marking everything non-reactive. Unfortunately, if I hide the window list LayoutManager sooner or later notices and changes the strut.
Created attachment 268183 [details] [review] window-list: fix overview animation Animate showing and hiding the window list when toggling the overview (with a translation on and off the screen). Don't actually change the visible status of the actor, because we don't want to change struts.
Created attachment 268184 [details] [review] WindowList: allow switching windows with mouse scroll This is something that gnome-panel supported, and apparently some users would like to have it back, so restore this feature on our window list too.
Review of attachment 268184 [details] [review]: OK. ::: extensions/window-list/extension.js @@ +853,3 @@ + let direction = event.get_scroll_direction(); + let diff = 0; + if (direction == Clutter.ScrollDirection.DOWN) { Style nit: no braces.
Review of attachment 268183 [details] [review]: The OSK position is wrong during overview transitions - in particular when it is visible while the overview is hiding, there's a visible jump at the end of the transition. So I think message tray and keyboard anchors need different behaviors: - the message tray anchor should be reset when the window list is not fully visible (otherwise it'll shine through) - the keyboard anchor should be reset when the window list is completely hidden
Created attachment 268323 [details] [review] window-list: Update keyboard position on fullscreen changes The visibility of the window list changes when a monitor enters or exits fullscreen, so we should update the OSK position accordingly. Drive-by fix ...
Review of attachment 268323 [details] [review]: Yes
Comment on attachment 268323 [details] [review] window-list: Update keyboard position on fullscreen changes Attachment 268323 [details] pushed as 9c23b52 - window-list: Update keyboard position on fullscreen changes
Comment on attachment 268184 [details] [review] WindowList: allow switching windows with mouse scroll Attachment 268184 [details] pushed as a42dcee - WindowList: allow switching windows with mouse scroll
Any plans for picking up the remaining patch, or should we close the bug?
(In reply to Florian Müllner from comment #9) > Any plans for picking up the remaining patch, or should we close the bug? I don't think I'll work on this any time soon, so if you want just close it.
(In reply to Giovanni Campagna from comment #10) > I don't think I'll work on this any time soon, so if you want just close it. OK.