GNOME Bugzilla – Bug 723668
Message Dialog Layout
Last modified: 2014-03-10 10:14:32 UTC
Created attachment 268162 [details] screenshots & style suggestions Visual issues I can see with message dialogs in master: * There's a lot of padding above the heading. It looks a bit unbalanced. * There's a bit too much padding between the heading and the body text - it looks like they are trying to get away from each other, rather than being related. * The small amount of padding around the buttons seems a little awkward - it's inconsistent with what we have elsewhere, and isn't clear whether it is deliberate or not. If we can't have 0 padding, the usual 6/12px might be better. * The hard corners on the buttons are, well, hard, and inconsistent with the corners of the dialog window as well as buttons elsewhere. Again, it's hard to tell whether it is deliberate or not. * In some places, one edge of the buttons seems to be getting cut off (see the left-hand edge of the cancel button in the attachment). The attachment shows some padding and style suggestions.
Bug 723228 is relevant, and has some screenshots of dialogs with buttons getting cut off.
*** Bug 723228 has been marked as a duplicate of this bug. ***
Perhaps going for the border buttons[1] for 3.12 was a bit premature. While they will visually be much more in place once we'd use them for notifications[2] and perhaps system dialogs, for now I'd go for the common paddings indeed. [1] http://jimmac.musichall.cz/stuff/border-buttons.png [2] https://dl.dropboxusercontent.com/u/5031519/gnome-shell/notifications/banners-and-activation.png
Created attachment 268322 [details] screenshot from master with latest theme for mutter
Created attachment 268324 [details] another screenshot Jon just shared a screenshot of what he's seeing for message dialogs, so clearly something is going wrong with the styling somwhere.
(In reply to comment #4) > Created an attachment (id=268322) [details] > screenshot from master with latest theme for mutter This is obviously much better than what I'm seeing. That said, a couple of things: * I think it would benefit from losing some vertical padding (roughly 6px above and below the heading, and 6px below the body text). * I'm not entirely sure about the square corners along the bottom of the dialog. They're inconsistent from the top, and they don't look like anything else we have in GNOME right now.
For 3.12 I agree with Jakub that it's still premature, those look out of place at the moment (to the point it looks like a layout bug for some persons). Could we go with the padding proposed in Allan's attachment? (we're entering UI freeze so it would be nice to agree to something quickly)
Just noticed this bug in the context of System Monitor[1], and I have some mixed feelings about them, after discussing a bit on IRC with bochecha, aday and fredp: * IOS 7[2] and Android [3] (and actually the gnome-shell notifications with buttons[4]) use border buttons, but the buttons themselves have no borders, what I'm seeing instead is that there's a horizontal separator between the button area and the content area, and there's a vertical separator between the buttons. * Right now our border buttons have double width borders, if they extend to the border of the dialog, as there's the dialog border and the button border on the edges, plus we have the dashed line on the default/focused (not sure what is causing the dashed line) button, which is yet another line, but that one has a padding of a few pixels. I think the situation could be improved by removing the duplicated borders (actually, the button borders, and replacing them with simple separators), or by adding back some padding to the buttons in the dialogs, like Allan suggested. [1] http://imgur.com/Gc9mYXu [2] http://wpuploads.appadvice.com/wp-content/uploads/2013/06/photo-576x1024.png [3] http://developer.android.com/images/ui/dialogs.png [4] https://dl.dropboxusercontent.com/u/5031519/gnome-shell/notifications/banners-and-activation.png
This bug is partially addressed by the patch in bug 725345.
Some of the issues have been addressed by bug 725345. One outstanding change that would be good is to increase the vertical space above the heading, as shown in this modified screenshot: https://bug725345.bugzilla-attachments.gnome.org/attachment.cgi?id=270811