After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723627 - The padding aroung the timelabel is wrong
The padding aroung the timelabel is wrong
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-04 19:01 UTC by Yosef Or Boczko
Modified: 2014-02-05 12:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (487.35 KB, image/png)
2014-02-04 19:01 UTC, Yosef Or Boczko 		  Details
widget: Fix margin-start and margin-end properties (1.52 KB, patch)
2014-02-05 09:39 UTC, Bastien Nocera 		committed Details | Review

Description Yosef Or Boczko 2014-02-04 19:01:08 UTC 
Created attachment 268087 [details]
Screenshot

See the screenshot.
Comment 1 Bastien Nocera 2014-02-05 09:21:17 UTC 
That wasn't what I was mentioning on IRC (and the close button was removed from fullscreen).

The problem is the padding around the time label (the "0:01" label touches the control buttons).
Comment 2 Bastien Nocera 2014-02-05 09:22:02 UTC 
The positioning of the "-" on the other time label is also weird.
Comment 3 Bastien Nocera 2014-02-05 09:34:30 UTC 
commit 3c0d4a59f99443f9e16a1779d839ea570ab45984
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Feb 5 10:26:18 2014 +0100

    main: Use "margin-start" and "margin-end"
    
    Rather than margin-left and margin-right.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723627


And found a bug in GTK+.
Comment 4 Bastien Nocera 2014-02-05 09:39:18 UTC 
Created attachment 268152 [details] [review]
widget: Fix margin-start and margin-end properties

The margin-start and margin-end properties were incorrectly
defined, so margins weren't respected for RTL languages.
Comment 5 Matthias Clasen 2014-02-05 12:25:49 UTC 
Review of attachment 268152 [details] [review]:

nice catch!
Comment 6 Bastien Nocera 2014-02-05 12:28:56 UTC 
Attachment 268152 [details] pushed as 4439453 - widget: Fix margin-start and margin-end properties