Review of attachment 267988 [details] [review]:

Thanks for the patch.

I think that checking if the permission is NULL right after we try to get it and returning immediately would be better. I'd also capture the GError from polkit_permission_new_sync() in that case and issue a warning.

(In reply to comment #1)
> Review of attachment 267988 [details] [review]:
> 
> Thanks for the patch.
> 
> I think that checking if the permission is NULL right after we try to get it
> and returning immediately would be better. I'd also capture the GError from
> polkit_permission_new_sync() in that case and issue a warning.

It that was my first idea. But IIRC I ended up with warning about GtkWidget being NULL or something at runtime.
I'll give it another try...

Yeah if I go your way I end up with this patch and this output (the WARNING is legit obviously, but the *-CRITICAL...):

--- panels/region/cc-region-panel.c.orig        Tue Feb  4 12:37:59 2014
+++ panels/region/cc-region-panel.c     Tue Feb  4 12:41:15 2014
@@ -1698,8 +1698,16 @@ setup_login_button (CcRegionPanel *self)
        CcRegionPanelPrivate *priv = self->priv;
         GDBusConnection *bus;
         gboolean loaded;
+        GError *error = NULL;
 
-        priv->permission = polkit_permission_new_sync ("org.freedesktop.locale1.set-locale", NULL, NULL, NULL);
+        priv->permission = polkit_permission_new_sync ("org.freedesktop.locale1.set-locale", NULL, NULL, &error);
+        if (priv->permission == NULL) {
+                g_warning ("Could not get 'org.freedesktop.locale1.set-locale' permission: %s",
+                           error->message);
+                g_error_free (error);
+                return;
+        }
+
         bus = g_bus_get_sync (G_BUS_TYPE_SYSTEM, NULL, NULL);
         g_dbus_proxy_new (bus,
                           G_DBUS_PROXY_FLAGS_GET_INVALIDATED_PROPERTIES



$ gnome-control-center                                         

(gnome-control-center:26694): region-cc-panel-WARNING **: Could not get 'org.freedesktop.locale1.set-locale' permission: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: Action org.freedesktop.locale1.set-locale is not registered

(gnome-control-center:26694): Gtk-CRITICAL **: gtk_box_pack: assertion 'GTK_IS_WIDGET (child)' failed

(gnome-control-center:26694): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

(gnome-control-center:26694): Gtk-CRITICAL **: gtk_size_group_add_widget: assertion 'GTK_IS_WIDGET (widget)' failed

(In reply to comment #3)

> $ gnome-control-center                                         
> 
> (gnome-control-center:26694): region-cc-panel-WARNING **: Could not get
> 'org.freedesktop.locale1.set-locale' permission:
> GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: Action
> org.freedesktop.locale1.set-locale is not registered

This is ok.

> (gnome-control-center:26694): Gtk-CRITICAL **: gtk_box_pack: assertion
> 'GTK_IS_WIDGET (child)' failed
> 
> (gnome-control-center:26694): GLib-GObject-CRITICAL **: g_object_ref: assertion
> 'G_IS_OBJECT (object)' failed
> 
> (gnome-control-center:26694): Gtk-CRITICAL **: gtk_size_group_add_widget:
> assertion 'GTK_IS_WIDGET (widget)' failed

This is because we are still trying to pack the login_button widget in the header bar. You could either skip that in _constructed() if (permission == NULL) or move the login_button setup before the permission initialization so that the widget is still constructed.

Created attachment 268074 [details] [review]
do not display "Login" if we can't get priv->permission v2

Yup. That updated patch seems to do the trick.

Review of attachment 268074 [details] [review]:

Thanks, this looks good, I'm going to push this with s/timedated/localed/ in the commit message and spin the 3.11.5 release.