After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723507 - jsseek: Add missing HAVE_X check
jsseek: Add missing HAVE_X check
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal trivial
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-03 01:36 UTC by Sebastian Rasmussen
Modified: 2014-02-04 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing compilation error. (834 bytes, patch)
2014-02-03 01:37 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-02-03 01:36:41 UTC 
If I configure gst-plugins-base like so:
./configure --disable-x

and I try to build it:
make -j10

I will end up with an error message:
jsseek.c:3000:72: error: ‘embed_xid’ undeclared (first use in this function)
   g_assert (embed_xid != 0);

This is due to the variable embed_xid only being declared if HAVE_X is set.
In this situation HAVE_X is not set but the reference to embed_xid is still there.
The attached patch fixes this issue.
Comment 1 Sebastian Rasmussen 2014-02-03 01:37:28 UTC 
Created attachment 267905 [details] [review]
Proposed patch fixing compilation error.
Comment 2 Sebastian Dröge (slomo) 2014-02-04 12:59:12 UTC 
commit 0f8f852776ab10b13b9a81d9c38b538a8c236579
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Mon Feb 3 02:35:57 2014 +0100

    jsseek: Add missing HAVE_X check
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=723507