After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723502 - gst-plugins-good: Do not build check tests for disabled plugins
gst-plugins-good: Do not build check tests for disabled plugins
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal trivial
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-03 00:58 UTC by Sebastian Rasmussen
Modified: 2014-02-26 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch that disables the check tests for disabled plugins. (2.38 KB, patch)
2014-02-03 01:00 UTC, Sebastian Rasmussen 		needs-work Details | Review
Proposed patch that disables the check tests for disabled plugins. (7.66 KB, patch)
2014-02-24 00:54 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-02-03 00:58:10 UTC 
This is similar to bug https://bugzilla.gnome.org/show_bug.cgi?id=723492
concerning gst-plugins-base except this one concerns gst-plugins-good

This time it is the audiofx, effectv and videomixer plugins that
can be disabled, but the corresponding tests are not. I aim to fix that.
Comment 1 Sebastian Rasmussen 2014-02-03 01:00:05 UTC 
Created attachment 267899 [details] [review]
Proposed patch that disables the check tests for disabled plugins.
Comment 2 Sebastian Dröge (slomo) 2014-02-04 13:02:25 UTC 
Review of attachment 267899 [details] [review]:

What about all the many other without-dependency plugin tests here?
Comment 3 Sebastian Rasmussen 2014-02-04 15:49:41 UTC 
I'm not sure I understand what you mean here..?
What do you mean by "without-dependency"?
Is this comment similar to the one in 723492 in that
you want me to add more --disable-flags so more tests
can be disabled?
Comment 4 Sebastian Dröge (slomo) 2014-02-04 16:07:42 UTC 
Yes
Comment 5 Sebastian Rasmussen 2014-02-24 00:54:24 UTC 
Created attachment 270082 [details] [review]
Proposed patch that disables the check tests for disabled plugins.
Comment 6 Sebastian Dröge (slomo) 2014-02-26 08:17:08 UTC 
commit b29d34de0c1192ae15b882ae263853f6ea60fb1f
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Mon Feb 3 01:44:21 2014 +0100

    tests: Don't build disabled plugins' check tests
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723502