GNOME Bugzilla – Bug 723380
codecparsers_h264: Add SEI recovery point message parsing.
Last modified: 2014-06-28 08:32:33 UTC
Created attachment 267741 [details] [review] codecparsers_h264: Add SEI recovery point message parsing For debugging purpose, I add the SEI recovery point message parsing in the h264 codecparser. If interested, i attached a patch which should apply on master.
LGTM. I will update and push it along with other codecparsers/h264 changes.
Created attachment 272851 [details] [review] codecparsers: h264: add support for Recovery Point SEI message
Review of attachment 272851 [details] [review]: Gwenole? Please push, but we don't use this "Signed-off-by:" stuff in the commit messages :)
Comment on attachment 272851 [details] [review] codecparsers: h264: add support for Recovery Point SEI message This patch won't apply anymore, would it be possible to rebase please ?
Gwenole's patch contains changes which are not in master yet, maybe related to his dev branch. However I could provide a patch rebased on master to add the feature. Just tell me.
Created attachment 278265 [details] [review] codecparsers: h264: add nal_reader_skip_long() helper Hi, sorry for being lamely long. Here is the minimal additional patch set needed before any additional patch for new SEI message support. i.e. we need to get the "skip unsupported SEI message" cases correct first. I can bear waiting for MVC patches integration, but this one would be the minimally useful one for most existing AVC cases. :) git pull --rebase'd locally for it. If this patch is OK with you, I can push both immediately.
Review of attachment 278265 [details] [review]: It looks good for me apart from a minor mismatch. ::: gst-libs/gst/codecparsers/nalutils.c @@ +131,3 @@ +/* Generic version to skip any number of bits */ +gboolean +nal_reader_skip_long (NalReader * nr, guint remaining) minor: mismatch between header definition and this about second parameter name
Review of attachment 272851 [details] [review]: Pushed to git master branch.
Review of attachment 278265 [details] [review]: Pushed to git master branch, and made the parameters consistent between header and source files. Checked the generated assembly to be semantically the same.
commit 67df2072801012dd084b4da6e916db9967f5650f Author: Aurélien Zanelli <aurelien.zanelli@parrot.com> Date: Fri Jan 31 17:07:42 2014 +0100 codecparsers: h264: add support for Recovery Point SEI message. The recovery point SEI message helps a decoder in determining if the decoding process would produce acceptable pictures for display after the decoder initiates random access or after the encoder indicates a broken link in the coded video sequence. This is not used in the h264parse element, but it could help debugging. https://bugzilla.gnome.org/show_bug.cgi?id=723380 commit 0440cabf491f2f6e82e7bcde24a805ee966cbaab Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com> Date: Tue Mar 25 12:01:55 2014 +0100 codecparsers: h264: add nal_reader_skip_long() helper. Add nal_reader_skip_long() helper function to allow an arbitrary number of bits to be skipped. The former nal_reader_skip() function is too limited to the actual cache size. Use this new function to simplify gst_h264_parser_parse_sei_message() default case, that skips unsupported payloads. v2: made args consistent from header to source file. Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>