After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723306 - overview: Fix DESKTOP clone position
overview: Fix DESKTOP clone position
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-30 18:07 UTC by Florian Müllner
Modified: 2014-01-30 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overview: Fix DESKTOP clone position (1.45 KB, patch)
2014-01-30 18:07 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2014-01-30 18:07:41 UTC
See patch.
Comment 1 Florian Müllner 2014-01-30 18:07:44 UTC
Created attachment 267663 [details] [review]
overview: Fix DESKTOP clone position

The DESKTOP window might not be located at (0,0), in particular
on multi-monitor setups. While we already consider this by setting
the clone's position, we then stuff the clone into a container which
ignores it - meh ...
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-30 20:14:58 UTC
Review of attachment 267663 [details] [review]:

::: js/ui/overview.js
@@ +495,2 @@
     fadeOutDesktop: function() {
+        if (!this._desktopFade.get_children().length)

get_num_children(); to prevent the GList from being made?
Comment 3 Florian Müllner 2014-01-30 23:01:14 UTC
Attachment 267663 [details] pushed as b97f3a9 - overview: Fix DESKTOP clone position