After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723054 - edsf-persona.vala:1666.21-1666.79: error: Reference transfer not supported for this expression
edsf-persona.vala:1666.21-1666.79: error: Reference transfer not supported fo...
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-26 20:57 UTC by Michael Catanzaro
Modified: 2014-01-29 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backends: Fix calls to ImDetails.normalise_im_address() (3.69 KB, patch)
2014-01-29 11:13 UTC, Philip Withnall
committed Details | Review

Description Michael Catanzaro 2014-01-26 20:57:41 UTC
I can't build folks with jhbuild:

  VALAC    libfolks_eds_la_vala.stamp
edsf-persona.vala:1666.21-1666.79: error: Reference transfer not supported for this expression
                    (owned) ImDetails.normalise_im_address ((!) addr, im_proto);
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona.vala:1723.21-1723.79: error: Reference transfer not supported for this expression
                    (owned) ImDetails.normalise_im_address (email.value, proto);
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

My Vala is 0.23.1.31-517d2
Comment 1 Philip Withnall 2014-01-29 11:13:41 UTC
Created attachment 267495 [details] [review]
backends: Fix calls to ImDetails.normalise_im_address()

Newer versions of the Vala compiler have got stricter about unnecessary
(owned) transfer annotations. Folks had some unnecessary ones, which
have now been removed. This shouldn’t affect compilation with older
versions of Vala, though this is untested.
Comment 2 Philip Withnall 2014-01-29 11:15:09 UTC
Thanks for the bug report. Fixed in master, and the fix will be included in the 0.9.7 release which should be made sometime in the next week or two.

Attachment 267495 [details] pushed as c9a9472 - backends: Fix calls to ImDetails.normalise_im_address()