Created attachment 266963 [details] [review]
0001-vaapidecode-add-vp8-support-in-configure.ac-and-Make

Created attachment 266964 [details] [review]
0002-vaapidecode-add-vp8-support-in-common-files

Created attachment 266965 [details] [review]
0003-vaapidecode-add-vp8-decoder-files

Review of attachment 266963 [details] [review]:

LGTM

Review of attachment 266964 [details] [review]:

LGTM

Review of attachment 266965 [details] [review]:

Tracking persistent frame data was better to be pushed to parser side, and not handle half of it in the decoder. This fixed a couple of more issues (clips). Resolutions could easily be tracked too, instead of relying on the very first one from GstCaps.

::: gst-libs/gst/vaapi/gstvaapidecoder_vp8.c
@@ +275,3 @@
+        temp_index < 0 ? 0 : (temp_index >
+        MAX_QI_INDEX ? MAX_QI_INDEX : temp_index);
+    iq_matrix->quantization_index[i][5] = temp_index;

This could have been much cleaner with standard CLAMP() macros.

@@ +353,3 @@
+  // reject frames for upscale, simple accept the downscale frames
+  if (priv->frame_width > priv->width || priv->frame_height > priv->height)
+    return FALSE;

horizontal_scale and vertical_scale are only useful for display and shall not affect the decoding process. In practice, it is not possible yet to honour the target display rect.

commit 029bae0b6a62a5bf46116ec73c2747f4692f5c51
Author: Zhao, Halley <halley.zhao@intel.com>
Date:   Fri Dec 27 07:18:24 2013 +0800

    Add initial VP8 decoder.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722761
    
    [complete overhaul, fixed support for resolution changes]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>