After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722699 - mpegtsmux: don't leak pad name when treating events
mpegtsmux: don't leak pad name when treating events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-21 14:48 UTC by Justin Kim
Modified: 2014-01-22 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegtsmux: don't leak pad name when treating events (2.37 KB, patch)
2014-01-21 14:49 UTC, Justin Kim 		needs-work Details | Review
GST_INFO_OBJECT (pad,... (1.72 KB, patch)
2014-01-21 15:05 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2014-01-21 14:48:33 UTC 
fixed gst_pad_get_name leakages.
Comment 1 Justin Kim 2014-01-21 14:49:26 UTC 
Created attachment 266877 [details] [review]
mpegtsmux: don't leak pad name when treating events
Comment 2 Sebastian Dröge (slomo) 2014-01-21 14:53:41 UTC 
Review of attachment 266877 [details] [review]:

::: gst/mpegtsmux/mpegtsmux.c
@@ +815,2 @@
       GST_INFO_OBJECT (mux, "have downstream force-key-unit event on pad %s, "
           "seqnum %d, running-time %" GST_TIME_FORMAT " count %d",

Just use GST_INFO_OBJECT (pad, ...)
Comment 3 Justin Kim 2014-01-21 15:05:56 UTC 
Created attachment 266883 [details] [review]
GST_INFO_OBJECT (pad,...

Good Review, Thanks.
Comment 4 Sebastian Dröge (slomo) 2014-01-22 09:12:22 UTC 
commit 99c2aa14c363c087ca690a698c40e11fb84ca118
Author: Justin Joy <justin.joy.9to5@gmail.com>
Date:   Tue Jan 21 23:42:58 2014 +0900

    mpegtsmux: don't leak pad name when treating events
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722699