After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722683 - Add AppData file
Add AppData file
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-21 11:32 UTC by Daniel Mustieles
Modified: 2014-01-22 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AppData file (2.14 KB, patch)
2014-01-21 11:32 UTC, Daniel Mustieles 		reviewed Details | Review
Patch updated (2.17 KB, patch)
2014-01-21 12:26 UTC, Daniel Mustieles 		none Details | Review
Updated patch (2.65 KB, patch)
2014-01-22 11:35 UTC, Daniel Mustieles 		committed Details | Review

Description Daniel Mustieles 2014-01-21 11:32:54 UTC 
Created attachment 266850 [details] [review]
AppData file

This patch adds the AppData file with the description suggested by Hughsie.
Comment 1 Emmanuele Bassi (:ebassi) 2014-01-21 11:39:00 UTC 
Review of attachment 266850 [details] [review]:

seems reasonable to me, and the patch looks good.

::: data/gnome-dictionary.appdata.xml.in
@@ +7,3 @@
+GNOME Dictionary is a simple dictionary application that looks up definitions of words online.
+Though it looks up English definitions by default, you can easily switch to
+Spanish or add other online dictionaries to suit your needs.

this is a bit misleading: Dictionary only supports DICT servers.

I'd probably use something like:

  "or add other online dictionaries using the DICT protocol to suit your needs."

I know that it is geeky, and I don't particularly like it either; but it's preferable to being misleading towards the users. at least, until such time we support other transports.
Comment 2 Daniel Mustieles 2014-01-21 12:26:24 UTC 
Created attachment 266857 [details] [review]
Patch updated

May thanks Emmanuele for your review.

Here is an updated patch, with you comment about DICT servers.
Comment 3 Daniel Mustieles 2014-01-22 11:35:47 UTC 
Created attachment 266968 [details] [review]
Updated patch

Added missing reference to POTFILES.in
Comment 4 Emmanuele Bassi (:ebassi) 2014-01-22 11:53:15 UTC 
Review of attachment 266968 [details] [review]:

looks good to me.
Comment 5 Daniel Mustieles 2014-01-22 11:58:30 UTC 
Review of attachment 266968 [details] [review]:

Thanks Emmanuele!
Comment 6 Daniel Mustieles 2014-01-22 12:07:54 UTC 
Commited. Thanks!