After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722642 - Use symbolic icon for file chooser
Use symbolic icon for file chooser
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.11.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-20 19:28 UTC by lamefun
Modified: 2014-01-22 02:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use symbolic icon for file chooser (920 bytes, patch)
2014-01-20 19:28 UTC, lamefun 		none Details | Review
Updated patch (7.07 KB, patch)
2014-01-20 20:14 UTC, lamefun 		none Details | Review
Updated patch (7.02 KB, patch)
2014-01-20 20:17 UTC, lamefun 		needs-work Details | Review
Remove the use of stock icons from widget templates (6.94 KB, patch)
2014-01-21 13:29 UTC, lamefun 		accepted-commit_now Details | Review
Use symbolic icon for file chooser (1.03 KB, patch)
2014-01-21 13:29 UTC, lamefun 		accepted-commit_now Details | Review

Description lamefun 2014-01-20 19:28:05 UTC 
Created attachment 266798 [details] [review]
Use symbolic icon for file chooser

patch
Comment 1 lamefun 2014-01-20 20:14:05 UTC 
Created attachment 266800 [details] [review]
Updated patch
Comment 2 lamefun 2014-01-20 20:17:32 UTC 
Created attachment 266801 [details] [review]
Updated patch
Comment 3 Matthias Clasen 2014-01-21 13:23:40 UTC 
Review of attachment 266801 [details] [review]:

Can you split this up into two patches ? One that just does stock -> icon-name conversion, and one that contains the change to a symbolic icon ? And the patch that switches to symbolic icons needs to set use-fallback to TRUE, so we don't break in symbolic-less environments
Comment 4 lamefun 2014-01-21 13:29:09 UTC 
Created attachment 266866 [details] [review]
Remove the use of stock icons from widget templates
Comment 5 lamefun 2014-01-21 13:29:46 UTC 
Created attachment 266867 [details] [review]
Use symbolic icon for file chooser
Comment 6 Matthias Clasen 2014-01-21 14:02:10 UTC 
Review of attachment 266866 [details] [review]:

sure
Comment 7 Matthias Clasen 2014-01-21 14:03:00 UTC 
Review of attachment 266867 [details] [review]:

ok. can you do me a favor and run make check after this to see if any of the tests need updating ?