After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722638 - Version the gio-2.0 and wayland-client requirements (gtk+ is using functions that only appeared in recent versions)
Version the gio-2.0 and wayland-client requirements (gtk+ is using functions ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.11.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-20 19:14 UTC by Adam Williamson
Modified: 2014-01-24 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: bump wayland-client dep to 1.3.90, require >= 2.39 of gio-2.0 (1.42 KB, patch)
2014-01-20 19:14 UTC, Adam Williamson 		reviewed Details | Review

Description Adam Williamson 2014-01-20 19:14:59 UTC 
Created attachment 266794 [details] [review]
build: bump wayland-client dep to 1.3.90, require >= 2.39 of gio-2.0

As per discussion on the anaconda development list:

https://www.redhat.com/archives/anaconda-devel-list/2014-January/msg00020.html
https://www.redhat.com/archives/anaconda-devel-list/2014-January/msg00021.html

gtk+ appears to be using functions from glib2 and wayland that only appeared in recent versions of those libraries. This patch (I believe) appropriately versions the pkgconfig requirements for those libraries in configure.ac . Please check carefully, I'm just the QA monkey. :) Patch is against current git master.
Comment 1 Matthias Clasen 2014-01-21 14:14:31 UTC 
Review of attachment 266794 [details] [review]:

::: configure.ac
@@ +414,3 @@
 PKG_PROG_PKG_CONFIG
 
+WAYLAND_DEPENDENCIES="wayland-client >= 1.3.90 xkbcommon >= 0.2.0 wayland-cursor"

The versions here should probably be pulled out into wayland_client_required_version.

@@ +1352,3 @@
 PKG_CHECK_MODULES(ATK, $ATK_PACKAGES)
 
+GTK_PACKAGES="atk cairo cairo-gobject gdk-pixbuf-2.0 gio-2.0 >= 2.39"

I'd rather have the versioning here generated from glib_required_version. Otherwise, we end up having to bump versions in two places instead of one. And if we start doing this for glib, might as well do it for atk, cairo and gdk-pixbuf as well.
Comment 2 Adam Williamson 2014-01-24 16:42:09 UTC 
mclasen: thanks for fixing this up, I had your notes in my head and meant to come back and adjust, but didn't get enough round tuits.