After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722527 - cp -d is not portable
cp -d is not portable
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-19 06:55 UTC by Ting-Wei Lan
Modified: 2014-02-09 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Replace non-portable cp -d (913 bytes, patch)
2014-01-19 11:55 UTC, Jens Georg 		none Details | Review
build: Replace non-portable cp -d (958 bytes, patch)
2014-02-09 12:11 UTC, Jens Georg 		committed Details | Review

Description Ting-Wei Lan 2014-01-19 06:55:28 UTC 
cp -d is used in doc/reference/doc-build.am, but the -d option is not specified in POSIX
standard.

This cause error when installing rygel on FreeBSD.

cp -d -R ./gtkdoc/html/* /home/lantw44/gnome/devinstall/_jhbuild/root-rygel/home/lantw44/gnome/devinstall/share/gtk-doc/html/librygel-core
cp: illegal option -- d
usage: cp [-R [-H | -L | -P]] [-f | -i | -n] [-alpvx] source_file target_file
       cp [-R [-H | -L | -P]] [-f | -i | -n] [-alpvx] source_file ... target_directory
gmake[6]: *** [install-data-hook] Error 64
gmake[6]: Leaving directory `/usr/home/lantw44/gnome/source/rygel/doc/reference/librygel-core'
Comment 1 Jens Georg 2014-01-19 11:55:12 UTC 
Created attachment 266649 [details] [review]
build: Replace non-portable cp -d
Comment 2 Ting-Wei Lan 2014-01-19 12:47:03 UTC 
--no-dereference is -P. Should -p be changed to -P?
Comment 3 Jens Georg 2014-02-01 13:57:21 UTC 
I used what autotools uses...
Comment 4 Ting-Wei Lan 2014-02-06 02:21:13 UTC 
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

If the -P option was specified, cp shall copy any symbolic link specified as a source_file operand and any symbolic links encountered during traversal of a file hierarchy, and shall not follow any symbolic links.


I think -d is similar to -P, not -p.
Comment 5 Jens Georg 2014-02-09 12:11:13 UTC 
Created attachment 268572 [details] [review]
build: Replace non-portable cp -d

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 6 Jens Georg 2014-02-09 12:19:32 UTC 
Attachment 268572 [details] pushed as f0ae3f0 - build: Replace non-portable cp -d