After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722515 - csd menu icon should use default window icon if per-window icon is not set
csd menu icon should use default window icon if per-window icon is not set
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-18 22:37 UTC by Yosef Or Boczko
Modified: 2014-01-24 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Set the icon name as "utilities-terminal" (883 bytes, patch)
2014-01-18 22:37 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2014-01-18 22:37:01 UTC 
For the fallback app-menu in the headerbar when
GTK_CSD=1.

See the patch.
Comment 1 Yosef Or Boczko 2014-01-18 22:37:39 UTC 
Created attachment 266635 [details] [review]
window: Set the icon name as "utilities-terminal"
Comment 2 Christian Persch 2014-01-18 22:59:06 UTC 
Why is this necessary? g-t already uses gtk_window_set_default_icon_name(), it's a bug if this isn't picked up by gtk csd, IMHO.
Comment 3 Yosef Or Boczko 2014-01-18 23:04:06 UTC 
I don't know why.
The headerbar use gtk_window_get_icon_list() for the
icon of the window.
Comment 4 Yosef Or Boczko 2014-01-18 23:06:44 UTC 
Sorry, my wrong, the headerbar use gtk_window_get_icon_list()
or gtk_window_get_icon_name() (the "icon-name" property):
https://git.gnome.org/browse/gtk+/tree/gtk/gtkheaderbar.c#n217
Comment 5 Christian Persch 2014-01-18 23:23:31 UTC 
So I think this should be handled by gtk.