After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722276 - vaapidecode: do not discard video info properties when the format is modified
vaapidecode: do not discard video info properties when the format is modified
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2014-01-15 16:38 UTC by Matthieu Bouron
Modified: 2014-06-18 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapidecode: set interlace-mode for gstreamer >= 1.2 (812 bytes, patch)
2014-01-15 16:41 UTC, Matthieu Bouron 		none Details | Review
vaapidecode: do not discard video info properties when the format is modified (2.57 KB, patch)
2014-03-15 15:31 UTC, Matthieu Bouron 		none Details | Review

Description Matthieu Bouron 2014-01-15 16:38:50 UTC 
This patch makes vaapidecode set interlace mode for gstreamer >= 1.0.
Comment 1 Matthieu Bouron 2014-01-15 16:41:29 UTC 
Created attachment 266368 [details] [review]
vaapidecode: set interlace-mode for gstreamer >= 1.2
Comment 2 Gwenole Beauchesne 2014-01-16 05:48:48 UTC 
Review of attachment 266368 [details] [review]:

::: gst/vaapi/gstvaapidecode.c
@@ +184,3 @@
     }
     state->caps = gst_video_info_to_caps(&vis);
+    gst_caps_set_interlaced(state->caps, vi);

Hmmm, no, I don't think this is needed because normally gst_video_info_to_caps() supports all of them already. Or did this change recently?
Comment 3 Matthieu Bouron 2014-03-15 15:31:36 UTC 
Created attachment 272018 [details] [review]
vaapidecode: do not discard video info properties when the format is modified

Patch updated. The video info properties was re initialized by gst_video_info_set_format thus discarding interlace mode, framerate, flags and pixel aspect ratio.
This patch takes care of copying those properties back to the video info structured after gst_video_info_set_format is called.
Comment 4 Gwenole Beauchesne 2014-06-18 12:04:53 UTC 
commit ead38a4d77d38bdc89c76e7856cb17bb73c698d2
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Wed Jan 15 16:36:29 2014 +0000

    vaapidecode: do not discard video info props when the format changed.
    
    gst_video_info_set_format() does not preserve video info properties. In
    order to keep important information in the caps such as interlace mode,
    framerate, pixel aspect ratio, ... we need to manually copy back those
    properties after setting the new video format.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722276